Skip to content

[Bugfix/#460] org 저장시 alert draft 값 반영 - #463

Merged
jjjsun merged 1 commit into
developfrom
bugfix/#460
Aug 13, 2026
Merged

[Bugfix/#460] org 저장시 alert draft 값 반영#463
jjjsun merged 1 commit into
developfrom
bugfix/#460

Conversation

@jjjsun

@jjjsun jjjsun commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

🚨 관련 이슈

Closed #460

✨ 변경사항

  • 🐞 BugFix Something isn't working
  • 💻 CrossBrowsing Browser compatibility
  • 🌏 Deploy Deploy
  • 🎨 Design Markup & styling
  • 📃 Docs Documentation writing and editing (README.md, etc.)
  • ✨ Feature Feature
  • 🔨 Refactor Code refactoring
  • ⚙️ Setting Development environment setup
  • ✅ Test Test related (storybook, jest, etc.)

✏️ 작업 내용

  • develop 에서 main으로 배포과정 중에 org 알림 저장할때 alertClick과 alertReport가 최신값인 draft 값이 아니라 이전 saved 값이 실릴 수도 있다는 점을 확인했습니다.
  • 그래서 buildOrgBody가 savedWorkspaceNotif를 암묵적으로 참조할 수 없도록, alert 값을 인자로 받도록 변경했습니다.
  • 저장/슬랙/디스코드 연동 에서도 draft 값 받도록 수정했습니다.

😅 미완성 작업

N/A

📢 논의 사항 및 참고 사항

💬 리뷰어 가이드 (P-Rules)
P1: 필수 반영 (Critical) - 버그 가능성, 컨벤션 위반. 해결 전 머지 불가.
P2: 적극 권장 (Recommended) - 더 나은 대안 제시. 가급적 반영 권장.
P3: 제안 (Suggestion) - 아이디어 공유. 반영 여부는 드라이버 자율.
P4: 단순 확인/칭찬 (Nit) - 사소한 오타, 칭찬 등 피드백.

@jjjsun
jjjsun requested review from Seojegyeong and YermIm August 12, 2026 17:56
@jjjsun jjjsun self-assigned this Aug 12, 2026
@jjjsun jjjsun added the 🐞 BugFix Something isn't working label Aug 12, 2026
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jjjsun, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 1 minute

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 40fff6bf-574d-41d2-b3c6-657a04f33c94

📥 Commits

Reviewing files that changed from the base of the PR and between c87304d and f78903e.

📒 Files selected for processing (2)
  • src/hooks/setting/useSettingNotifications.ts
  • src/hooks/setting/useSettingSave.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown

📚 Storybook 배포 완료

항목 링크
📖 Storybook https://69a147b60a56365d9e2185ef-xgaiglmutd.chromatic.com/
🔍 Chromatic https://www.chromatic.com/build?appId=69a147b60a56365d9e2185ef&number=641

YermIm
YermIm approved these changes Aug 12, 2026
View reviewed changes

@YermIm YermIm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P4: 확인했습니다!

Seojegyeong
Seojegyeong approved these changes Aug 13, 2026
View reviewed changes

@Seojegyeong Seojegyeong left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P4: 확인했습니다!

@jjjsun
jjjsun merged commit 257ce8d into develop Aug 13, 2026
3 checks passed
@jjjsun
jjjsun deleted the bugfix/#460 branch August 13, 2026 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YermIm YermIm YermIm approved these changes
@Seojegyeong Seojegyeong Seojegyeong approved these changes

Assignees

@jjjsun jjjsun

Labels

🐞 BugFix Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐞 [BugFix] org 알림 저장 시 alert 값이 saved로 전송되는 문제 해결

3 participants

@jjjsun @YermIm @Seojegyeong